[mb-bugs] [MusicBrainz Bug Tracker] #5842: plugin - cover art downloader - kills wma files

[MusicBrainz Bug Tracker]

#5842: plugin - cover art downloader - kills wma files
---------------------------+------------------------------------------------
Reporter: n00ris | Type: bug
Status: new | Priority: important
Milestone: | Component: Picard Tagger
Version: Picard 0.12.1 | Keywords:
Os: Linux | Browser:
---------------------------+------------------------------------------------
I hope this is the right place for "plugin" bugs (I guessd so because
tickets are listed at the plugin overview website). The cover art
downloader tags the files automatically, independend if the filetype is
supported. After saving a tagged wma file and reloading it with picard,
all tags are gone (inklusive the playtime of the song and this cannot be
restored) and picard shows an error symbol in front of the songname.

Log says:
UnicodeDecodeError: 'utf16' codec can't decode bytes in position 20-21:
illegal UTF-16 surrogate

I don't know how to delete the cover now.

grettings
N00ris

[MusicBrainz Bug Tracker]

#5842: plugin - cover art downloader - kills wma files
----------------------------+-----------------------------------------------
Reporter: n00ris | Owner:
Type: bug | Status: new
Priority: important | Milestone:
Component: Picard Tagger | Version: Picard 0.12.1
Resolution: | Keywords:
Os: Linux | Browser:
----------------------------+-----------------------------------------------
Comment (by voiceinsideyou):

I believe this might have been a known issue with Picard 0.12.1 (and the
underlying tagging library) that may be fixed in Picard 0.13. Can you
please retest with the new version?

[MusicBrainz Bug Tracker]

#5842: plugin - cover art downloader - kills wma files
----------------------------+-----------------------------------------------
Reporter: n00ris | Owner:
Type: bug | Status: closed
Priority: important | Milestone: Picard 0.13
Component: Picard Tagger | Version: Picard 0.12.1
Resolution: fixed | Keywords:
Os: Linux | Browser:
----------------------------+-----------------------------------------------
Changes (by outsidecontext):

* status: new => closed
* resolution: => fixed
* milestone: => Picard 0.13

Comment:

I am really sorry for this bug, it has been fixed in Picard 0.13. Actually
this was a combination of a bug in the Mutagen library and image files
larger than 64KB.

Unfortunately I don't know how you can restore the file. If you still have
the broken file you can send it to ph.wolfer AT googlemail DOT com I can
take a look at it.

[MusicBrainz Bug Tracker]

#5842: plugin - cover art downloader - kills wma files
----------------------------+-----------------------------------------------
Reporter: n00ris | Owner:
Type: bug | Status: closed
Priority: important | Milestone: Picard 0.13
Component: Picard Tagger | Version: Picard 0.12.1
Resolution: fixed | Keywords:
Os: Linux | Browser:
----------------------------+-----------------------------------------------
Comment (by anonymous):

Resaving in Picard 0.13 should fix the files.

[MusicBrainz Bug Tracker]

#5842: plugin - cover art downloader - kills wma files
----------------------------+-----------------------------------------------
Reporter: n00ris | Owner:
Type: bug | Status: closed
Priority: important | Milestone: Picard 0.13
Component: Picard Tagger | Version: Picard 0.12.1
Resolution: fixed | Keywords:
Os: Linux | Browser:
----------------------------+-----------------------------------------------
Comment (by luks):

Oh, hm, ignore the previous comment. I didn't realize that even Picard
couldn't read the files. I'd be very interested in seeing the files,
because I think that Picard should be able to read them just fine.

[MusicBrainz Bug Tracker]

#5842: plugin - cover art downloader - kills wma files
----------------------------+-----------------------------------------------
Reporter: n00ris | Owner:
Type: bug | Status: closed
Priority: important | Milestone: Picard 0.13
Component: Picard Tagger | Version: Picard 0.12.1
Resolution: fixed | Keywords:
Os: Linux | Browser:
----------------------------+-----------------------------------------------

Post by MusicBrainz Bug Tracker
I am really sorry for this bug, it has been fixed in Picard 0.13.

Actually this was a combination of a bug in the Mutagen library and image
files larger than 64KB.

Ah, thank you, I couldn't reproduce this with 0.12.1 on gentoo-linux. Its
may because I couldn't find a convenient wma file.

Post by MusicBrainz Bug Tracker
Unfortunately I don't know how you can restore the file. If you still

have the broken file you can send it to ph.wolfer AT googlemail DOT com I
can take a look at it.

Thanks for the offer, but at the moment I it is playable with mplayer or
mpd/mpc.

BTW / offtopic: It is possible to remove a cover with picard in general
(if they are saved as tags)?

Post by MusicBrainz Bug Tracker
Resaving in Picard 0.13 should fix the files.

No. Picard cannot change any tags.

Post by MusicBrainz Bug Tracker
Oh, hm, ignore the previous comment. I didn't realize that even Picard

couldn't read the files. I'd be very interested in seeing the files,
because I think that Picard should be able to read them just fine.

Sorry, I have no "free" file, I tried to create an example-file but how I
can tell picard / the plugin to add a cover to my own generated .wma
file...

[MusicBrainz Bug Tracker]

#5842: plugin - cover art downloader - kills wma files
----------------------------+-----------------------------------------------
Reporter: n00ris | Owner:
Type: bug | Status: closed
Priority: important | Milestone: Picard 0.13
Component: Picard Tagger | Version: Picard 0.12.1
Resolution: fixed | Keywords:
Os: Linux | Browser:
----------------------------+-----------------------------------------------
Comment (by luks):

If you install this plugin http://dl.dropbox.com/u/5215054/fix_wma.py,
Picard should be able to read the files and resaving should fix them.

[MusicBrainz Bug Tracker]

#5842: plugin - cover art downloader - kills wma files
----------------------------+-----------------------------------------------
Reporter: n00ris | Owner:
Type: bug | Status: closed
Priority: important | Milestone: Picard 0.13
Component: Picard Tagger | Version: Picard 0.12.1
Resolution: fixed | Keywords:
Os: Linux | Browser:
----------------------------+-----------------------------------------------

Post by MusicBrainz Bug Tracker
If you install this plugin http://dl.dropbox.com/u/5215054/fix_wma.py,

Picard should be able to read the files and resaving should fix them.

Sorry, does not work with picard 0.13, I get the following output on the
console if I try to save the file:

File "/usr/lib64/python2.6/site-packages/picard/util/thread.py", line
80, in generic_run_item
result = func()
File "/usr/lib64/python2.6/site-packages/picard/file.py", line 147, in
_save_and_rename
self._save(old_filename, metadata, settings)
File "/usr/lib64/python2.6/site-packages/picard/formats/asf.py", line
141, in _save
file = ASF(encode_filename(filename))
File "/usr/lib64/python2.6/site-packages/mutagen/__init__.py", line 75,
in __init__
self.load(filename, *args, **kwargs)
File "/usr/lib64/python2.6/site-packages/mutagen/asf.py", line 577, in
load
self.__read_file(fileobj)
File "/usr/lib64/python2.6/site-packages/mutagen/asf.py", line 654, in
__read_file
self.__read_object(fileobj)
File "/usr/lib64/python2.6/site-packages/mutagen/asf.py", line 663, in
__read_object
obj.parse(self, data, fileobj, size)
File "/home/linux/.config/MusicBrainz/Picard/plugins/fix_wma.py", line
18, in patched_ExtendedContentDescriptionObject_parse
name_length, = struct.unpack("<H", data[pos:pos+2])
error: unpack requires a string argument of length 2

[MusicBrainz Bug Tracker]

#5842: plugin - cover art downloader - kills wma files
----------------------------+-----------------------------------------------
Reporter: n00ris | Owner:
Type: bug | Status: closed
Priority: important | Milestone: Picard 0.13
Component: Picard Tagger | Version: Picard 0.12.1
Resolution: fixed | Keywords:
Os: Linux | Browser:
----------------------------+-----------------------------------------------
Comment (by luks):

Hm, it must be a different kind of situation. It should work on the file
you sent to Philipp. I've have to see this file in order to modify the
code to catch this case.